feat: support drag-reordering of dashboard items #7738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomivirkki
force-pushed
the
feat/dashboard-widget-reorder
branch
from
dd47211
to
ae337ee
Compare
…ard-widget-reorder # Conflicts: # packages/dashboard/src/vaadin-dashboard-section.js # packages/dashboard/test/helpers.ts
ugur-vaadin
reviewed
Sep 4, 2024
ugur-vaadin
approved these changes
Sep 4, 2024
Co-authored-by: Ugur Saglam <[email protected]>
# Conflicts: # packages/dashboard/src/vaadin-dashboard-section.js # packages/dashboard/test/helpers.ts
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for DnD reordering of
<vaadin-dashboard>widgets and sectionsKapture.2024-09-02.at.09.54.19.mp4
Added API:
editableif true, the widget/section header controls are visibledashboard-item-reorder-start: Fired when item reordering startsdashboard-item-reorder-end: Fired when item reordering endsdashboard-item-drag-reorder: Fired when an items will be reordered by draggingevent.item: The item being draggedevent.targetIndex: The new index of the item in its hostitemsarrayFixes https://github.com/orgs/vaadin/projects/70/views/1?pane=issue&itemId=74625606
Part of vaadin/platform#6626
Type of change
Feature