chore: add nim 2 to ci (#8)

* add nim 2 to ci * fix trigger * remove ConvFromXtoItselfNotNeeded
vacp2p · Sep 3, 2024 · 6834f47 · 6834f47
1 parent 817de8e
commit 6834f47
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -1,20 +1,26 @@
 name: CI
 
-on: [push, pull_request]
+on:
+  push:
+      branches:
+      - main
+  pull_request:
+  workflow_dispatch:
 
 jobs:
   test:
     runs-on: ${{ matrix.os }}
     strategy:
       matrix:
         os: [ubuntu-latest, macOS-latest, windows-latest]
+        nim: [1.6.20, stable]
     steps:
     - uses: actions/checkout@v2
       with:
         submodules: true
     - uses: iffy/install-nim@v5
       with:
-        version: 1.6.20
+        version: ${{ matrix.nim }}
     - name: Build
       run: nimble install -y
     - name: Test

diff --git a/ngtcp2.nim b/ngtcp2.nim
@@ -29,7 +29,6 @@ const buildInclude = root/"build"/"lib"/"includes"
 # const 'NGTCP2_CONN_INFO_VERSION' has unsupported value 'NGTCP2_CONN_INFO_V1'
 # const 'NGTCP2_SETTINGS_VERSION' has unsupported value 'NGTCP2_SETTINGS_V2'
 # const 'NGTCP2_CALLBACKS_VERSION' has unsupported value 'NGTCP2_CALLBACKS_V1'
-{.push hint[ConvFromXtoItselfNotNeeded]: off.}
 import macros
 
 macro defineEnum(typ: untyped): untyped =
@@ -3811,4 +3810,3 @@ proc ngtcp2_select_version*(preferred_versions: ptr uint32;
                                                                                  ##    Negotiation packet.  If no version is selected, this function
                                                                                  ##    returns 0.
                                                                                  ## ```
-{.pop.}