This repository has been archived by the owner on Jun 14, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat(51/WAKU2-RELAY-SHARDING): Autosharding update #607
feat(51/WAKU2-RELAY-SHARDING): Autosharding update #607
Changes from 8 commits
b82119b
ae85757
efdcf79
af6cdd4
ef40f13
1c27c54
f722eff
dfb21fa
40a9dec
6634de8
25bc2f1
88d58ad
0bf46ce
12a5898
854ad11
bd1c714
d9bd7ce
ad7ff72
49d7fa1
ffdc7ee
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this strictly true? In other words, if an application uses multiple application fields the impact is that the traffic for that application will be routed in different shards which adds routing complexity and may increase relayed traffic. However, the application could still e.g. use filter to subscribe to content from all these shards without relaying, but this adds complexity.
I think from this RFC's perspective there is no definitive knowledge about implied relay (or not) of different shards - this happens at another layer - but we could add that applications SHOULD consider the added complexity and possible bandwidth implication of possibly splitting their traffic across several shards by using multiple
application
fields. In fact, the recommendation is that application designers SHOULD group traffic that needs to be processed together with the sameapplication
field and SHOULD use differentapplication
fields for traffic that can be processed separately, to increase scalability.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True and it also apply to this below.
We can't make that statement either. It's a case by case basis.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
True, but in the latter case I think the
SHOULD
implies that there's a general best practice scenario here and we might want to be somewhat helpful to those completely new to the concept. But no major objection to leaving this out.