Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test pluggable validation logic #22

Merged
merged 3 commits into from
Jul 27, 2023
Merged

test pluggable validation logic #22

merged 3 commits into from
Jul 27, 2023

Conversation

rymnc
Copy link
Contributor

@rymnc rymnc commented Jul 26, 2023

  • chore: convert rln to rlnbase, and inherit into rln

@rymnc rymnc force-pushed the test-pluggable-validation-logic branch from ba3aee3 to deb10ad Compare July 26, 2023 10:46
@github-actions
Copy link

LCOV of commit 57411cc during CI #22

Summary coverage rate:
  lines......: 83.9% (496 of 591 lines)
  functions..: 48.0% (12 of 25 functions)
  branches...: 52.5% (21 of 40 branches)

Files changed coverage rate:
                              |Lines       |Functions  |Branches    
  Filename                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================
  contracts/PoseidonHasher.sol| 100%    461| 100%     2|    -      0
  contracts/RlnBase.sol       |97.0%     33|85.7%     7| 100%     18
  contracts/RlnVerifier.sol   | 0.0%     93| 0.0%    12| 0.0%     18
  test/RLNApp.t.sol           | 100%      2| 100%     2|75.0%      4
  test/Verifier.sol           |50.0%      2| 100%     2|    -      0

@rymnc rymnc force-pushed the test-pluggable-validation-logic branch from 57411cc to 37f9c37 Compare July 26, 2023 10:57
@rymnc rymnc force-pushed the test-pluggable-validation-logic branch from 37f9c37 to 766366c Compare July 26, 2023 11:11
@github-actions
Copy link

LCOV of commit 766366c during CI #23

Summary coverage rate:
  lines......: 83.9% (496 of 591 lines)
  functions..: 48.0% (12 of 25 functions)
  branches...: 52.5% (21 of 40 branches)

Files changed coverage rate:
                              |Lines       |Functions  |Branches    
  Filename                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================
  contracts/PoseidonHasher.sol| 100%    461| 100%     2|    -      0
  contracts/RlnBase.sol       |97.0%     33|85.7%     7| 100%     18
  contracts/RlnVerifier.sol   | 0.0%     93| 0.0%    12| 0.0%     18
  test/RLNApp.t.sol           | 100%      2| 100%     2|75.0%      4
  test/Verifier.sol           |50.0%      2| 100%     2|    -      0

@github-actions
Copy link

LCOV of commit 5d3b5dd during CI #24

Summary coverage rate:
  lines......: 83.9% (496 of 591 lines)
  functions..: 48.0% (12 of 25 functions)
  branches...: 52.5% (21 of 40 branches)

Files changed coverage rate:
                              |Lines       |Functions  |Branches    
  Filename                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================
  contracts/PoseidonHasher.sol| 100%    461| 100%     2|    -      0
  contracts/RlnBase.sol       |97.0%     33|85.7%     7| 100%     18
  contracts/RlnVerifier.sol   | 0.0%     93| 0.0%    12| 0.0%     18
  test/RLNApp.t.sol           | 100%      2| 100%     2|75.0%      4
  test/Verifier.sol           |50.0%      2| 100%     2|    -      0

@rymnc
Copy link
Contributor Author

rymnc commented Jul 27, 2023

Looks like slither doesn't throw up any vulns, merging.

@rymnc rymnc marked this pull request as ready for review July 27, 2023 05:09
@github-actions
Copy link

LCOV of commit 5cbeb45 during CI #25

Summary coverage rate:
  lines......: 83.9% (496 of 591 lines)
  functions..: 48.0% (12 of 25 functions)
  branches...: 52.5% (21 of 40 branches)

Files changed coverage rate:
                              |Lines       |Functions  |Branches    
  Filename                    |Rate     Num|Rate    Num|Rate     Num
  ==================================================================
  contracts/PoseidonHasher.sol| 100%    461| 100%     2|    -      0
  contracts/RlnBase.sol       |97.0%     33|85.7%     7| 100%     18
  contracts/RlnVerifier.sol   | 0.0%     93| 0.0%    12| 0.0%     18
  test/RLNApp.t.sol           | 100%      2| 100%     2|75.0%      4
  test/Verifier.sol           |50.0%      2| 100%     2|    -      0

@rymnc rymnc merged commit 4e14c58 into main Jul 27, 2023
1 check passed
@rymnc rymnc deleted the test-pluggable-validation-logic branch July 27, 2023 05:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rymnc