fix: make tests compile with [email protected] #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a breaking change introduced in `forge-std` at foundry-rs/forge-std#407 which breaks compilation of `Rln.t.sol` with `[email protected]`. This commit updates the dependency to v1.6.0 and adjusts the test source such that it successfully compiles. Another way to go about this would've been to just stick with `v1.5.6.` and ensuring installation of that version. However, I've decided to update the dependency to the latest stable version instead.
|
Unfortunately, GitHub still doesn't support preserving PGP verified signatures of a commit when using the "Rebase & Merge" button via the web interface, hence the merged commit is now marked as not verified. Switching to "Squash and merge" instead for future PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a breaking change introduced in
forge-stdat foundry-rs/forge-std#407 which breaks compilation ofRln.t.solwith[email protected].This commit updates the dependency to v1.6.0 and adjusts the test source such that it successfully compiles.
Another way to go about this would've been to just stick with
v1.5.6.and ensuring installation of that version.However, I've decided to update the dependency to the latest stable version instead.