chore: remove linter warning and errors

vacp2p · Oct 9, 2024 · ceed245 · ceed245
1 parent f36d85a
commit ceed245
Show file tree

Hide file tree

Showing 3 changed files with 10 additions and 9 deletions.
diff --git a/src/nft-metadata-generators/NFTMetadataGeneratorSVG.sol b/src/nft-metadata-generators/NFTMetadataGeneratorSVG.sol
@@ -3,7 +3,6 @@ pragma solidity ^0.8.26;
 
 import { Base64 } from "@openzeppelin/contracts/utils/Base64.sol";
 import { Strings } from "@openzeppelin/contracts/utils/Strings.sol";
-import { Ownable } from "@openzeppelin/contracts/access/Ownable.sol";
 import { BaseNFTMetadataGenerator } from "./BaseNFTMetadataGenerator.sol";
 
 contract NFTMetadataGeneratorSVG is BaseNFTMetadataGenerator {

diff --git a/test/nft-metadata-generators/NFTMetadataGeneratorSVG.t.sol b/test/nft-metadata-generators/NFTMetadataGeneratorSVG.t.sol
@@ -1,17 +1,17 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.26;
 
-import { Test, console } from "forge-std/Test.sol";
+import { Test } from "forge-std/Test.sol";
 import { Base64 } from "@openzeppelin/contracts/utils/Base64.sol";
 import { Ownable } from "@openzeppelin/contracts/access/Ownable.sol";
 import { MockToken } from "../mocks/MockToken.sol";
 import { NFTMetadataGeneratorSVG } from "../../src/nft-metadata-generators/NFTMetadataGeneratorSVG.sol";
 
 contract NFTMetadataGeneratorSVGTest is Test {
-    MockToken erc20Token;
-    NFTMetadataGeneratorSVG metadataGenerator;
+    MockToken private erc20Token;
+    NFTMetadataGeneratorSVG private metadataGenerator;
 
-    address alice = makeAddr("alice");
+    address private alice = makeAddr("alice");
 
     function setUp() public {
         erc20Token = new MockToken("Test", "TEST");
@@ -23,6 +23,7 @@ contract NFTMetadataGeneratorSVGTest is Test {
     function testGenerateMetadata() public view {
         string memory expectedName = "XPNFT Token 0x328809bc894f92807417d2dad6b7c998c1afdac6";
         string memory expectedDescription =
+        // solhint-disable-next-line
             "This is a XPNFT token for address 0x328809bc894f92807417d2dad6b7c998c1afdac6 with balance 10000000000000000000";
         string memory encodedImage = Base64.encode(abi.encodePacked("<svg>10</svg>"));
         string memory expectedImage = string(abi.encodePacked("data:image/svg+xml;base64,", encodedImage));

diff --git a/test/nft-metadata-generators/NFTMetadataGeneratorURL.t.sol b/test/nft-metadata-generators/NFTMetadataGeneratorURL.t.sol
@@ -1,17 +1,17 @@
 // SPDX-License-Identifier: MIT
 pragma solidity ^0.8.26;
 
-import { Test, console } from "forge-std/Test.sol";
+import { Test } from "forge-std/Test.sol";
 import { Base64 } from "@openzeppelin/contracts/utils/Base64.sol";
 import { Ownable } from "@openzeppelin/contracts/access/Ownable.sol";
 import { MockToken } from "../mocks/MockToken.sol";
 import { NFTMetadataGeneratorURL } from "../../src/nft-metadata-generators/NFTMetadataGeneratorURL.sol";
 
 contract NFTMetadataGeneratorURLTest is Test {
-    MockToken erc20Token;
-    NFTMetadataGeneratorURL metadataGenerator;
+    MockToken private erc20Token;
+    NFTMetadataGeneratorURL private metadataGenerator;
 
-    address alice = makeAddr("alice");
+    address private alice = makeAddr("alice");
 
     function setUp() public {
         erc20Token = new MockToken("Test", "TEST");
@@ -24,6 +24,7 @@ contract NFTMetadataGeneratorURLTest is Test {
         string memory expectedMetadata = "data:application/json;base64,";
         bytes memory json = abi.encodePacked(
             "{\"name\":\"XPNFT Token 0x328809bc894f92807417d2dad6b7c998c1afdac6\",",
+            // solhint-disable-next-line
             "\"description\":\"This is a XPNFT token for address 0x328809bc894f92807417d2dad6b7c998c1afdac6 with balance 10000000000000000000\",",
             "\"image\":\"http://test.local/images/0x328809bc894f92807417d2dad6b7c998c1afdac6.jpg\"}"
         );