add base XPToken with IXPProvider interface #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gravityblast
force-pushed
the
xp-token-providers
branch
from
c6a0310
to
bce7a88
Compare
gravityblast
changed the title
0x-r4bbit
reviewed
Oct 8, 2024
0x-r4bbit
approved these changes
Oct 10, 2024
| "verify": "certoraRun certora/certora.conf", | ||
| "verify": "pnpm verify:rewards_streamer_mp && pnpm verify:xp_token", | ||
| "verify:rewards_streamer_mp": "certoraRun certora/confs/RewardsStreamerMP.conf", | ||
| "verify:xp_token": "certoraRun certora/confs/XPToken.conf", |
There was a problem hiding this comment.
We might want to introduce separate CI tasks for these in the github action. But can do that in a follow-up PR
src/XPToken.sol
Outdated
|
|
||
| function balanceOf(address account) public view returns (uint256) { | ||
| uint256 userTotalXPContribution = 0; | ||
| uint256 totalXPContribution = 0; |
There was a problem hiding this comment.
I think we wanted to rename this to shares no?
There was a problem hiding this comment.
@0x-r4bbit yes I renamed the storage vars but not these local ones, I'm doing it now
|
@gravityblast can you run |
gravityblast
force-pushed
the
xp-token-providers
branch
from
c615a4e
to
75e34f0
Compare
0x-r4bbit
approved these changes
Oct 11, 2024
…d of contribution
gravityblast
force-pushed
the
xp-token-providers
branch
from
75e34f0
to
c77c795
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Describe the changes made in your pull request here.
Checklist
Ensure you completed all of the steps below before submitting your pull request:
pnpm adorno?pnpm verify?closes #41