Add runFlags test and fix bugs

val-town · May 1, 2024 · d8d2aa5 · d8d2aa5
1 parent b930937
commit d8d2aa5
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/DenoHTTPWorker.test.ts b/src/DenoHTTPWorker.test.ts
@@ -41,6 +41,22 @@ describe("DenoHTTPWorker", { timeout: 1000 }, () => {
     worker.terminate();
   });
 
+  describe("runFlags editing", () => {
+    it.each([
+      "--allow-read",
+      "--allow-write",
+      "--allow-read=/dev/null",
+      "--allow-write=/dev/null",
+    ])("should handle %s", async (flag) => {
+      let worker = await newDenoHTTPWorker(echoScript, {
+        printOutput: true,
+        runFlags: [flag],
+      });
+      await worker.client.get("https://localhost/").json();
+      await worker.terminate();
+    });
+  });
+
   it("should be able to import script", async () => {
     const file = path.resolve(__dirname, "./test/echo-request.ts");
     const url = new URL(`file://${file}`);
@@ -60,7 +76,6 @@ describe("DenoHTTPWorker", { timeout: 1000 }, () => {
   it("user agent is not overwritten", async () => {
     let worker = await newDenoHTTPWorker(echoScript, {
       printOutput: true,
-      runFlags: [`--unstable-http`],
     });
     let resp: any = await worker.client
       .get("https://localhost/", {

diff --git a/src/DenoHTTPWorker.ts b/src/DenoHTTPWorker.ts
@@ -102,7 +102,7 @@ export const newDenoHTTPWorker = async (
       return (flag += "," + allowReadFlagValue);
     }
     if (flag.startsWith("--allow-write=")) {
-      allowReadFound = true;
+      allowWriteFound = true;
       return (flag += "," + socketFile);
     }
     return flag;