Skip to content

Commit

Permalink
Merge pull request #95 from valida-xyz/fix_mul_padding_rows
Browse files Browse the repository at this point in the history
Fix padding rows in `Mul32Chip`
  • Loading branch information
dlubarov authored Jan 11, 2024
2 parents bd6d505 + 1c80710 commit 7f83a73
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 3 deletions.
2 changes: 0 additions & 2 deletions alu_u32/src/mul/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -50,12 +50,10 @@ where
}

// Encode dummy operations as needed to pad the trace.
let dummy_op = Operation::Mul32(Word::default(), Word::default(), Word::default());
for i in num_ops..num_padded_ops {
let row = &mut values[i * NUM_MUL_COLS..(i + 1) * NUM_MUL_COLS];
let cols: &mut Mul32Cols<F> = row.borrow_mut();
cols.counter = F::from_canonical_usize(i + 1);
self.op_to_row(&dummy_op, cols);
}

RowMajorMatrix {
Expand Down
1 change: 0 additions & 1 deletion basic/tests/test_prover.rs
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@ use rand::thread_rng;
use valida_machine::__internal::p3_commit::ExtensionMmcs;

#[test]
#[ignore] // TODO: Bus arguments are failing?
fn prove_fibonacci() {
let mut program = vec![];

Expand Down

0 comments on commit 7f83a73

Please sign in to comment.