Static data chip #134
Merged
Static data chip #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These changes comment out the memory argument constraints. I'm not sure this is necessary, but I found it convenient to do so since we're convinced that the memory argument is unsound anyway, and Hadas is going to replace it. |
morganthomas
force-pushed
the
morgan/issue/133
branch
from
1ca280c to
0923418
Compare
thealmarty
reviewed
Apr 2, 2024
|
Because of the commented out code the warnings are getting out of hand. I've cleaned up as much as makes sense so we can still track them. Please merge #136 into this before merging this, if it's ok with you. |
thealmarty
reviewed
Apr 2, 2024
| @@ -179,6 +206,7 @@ impl MemoryChip { | |||
|
|
|||
| cols.clk = F::from_canonical_usize(clk); | |||
| cols.counter = F::from_canonical_usize(n); | |||
| cols.is_static_initial = F::zero(); | |||
There was a problem hiding this comment.
I think this is not needed as it is set to zero on L204.
thealmarty
reviewed
Apr 2, 2024
| let mut row = [F::zero(); NUM_MEM_COLS]; | ||
| let cols: &mut MemoryCols<F> = unsafe { transmute(&mut row) }; | ||
| cols.is_static_initial = F::one(); | ||
| cols.clk = F::zero(); |
There was a problem hiding this comment.
Similarly for these lines that set the values to zeros.
thealmarty
approved these changes
Apr 2, 2024
Clean up warnings.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #133