Better use of generics #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses some limitations that were getting in the way of finishing the prover. - Removes `FE` from `Machine` - it's not really inherent to the machine, and we have it in `StarkConfig`. - Give `Instruction` a `F: Field` generic, so we can have instructions which only support certain fields. - Give `Chip` a `SC: StarkConfig` generic, so we can have chips which only support certain fields etc. (I think ideally it would be `F: Field` as above rather than `SC: StarkConfig`, but Rust doesn't support bounds like `Chip<...>: for<'a> for<SC> Air<ConstraintFolder<'a, M, SC>>`.)
morganthomas
approved these changes
Jan 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses some limitations that were getting in the way of finishing the prover.
FEfromMachine- it's not really inherent to the machine, and we have it inStarkConfig.InstructionaF: Fieldgeneric, so we can have instructions which only support certain fields.ChipaSC: StarkConfiggeneric, so we can have chips which only support certain fields etc. (I think ideally it would beF: Fieldas above rather thanSC: StarkConfig, but Rust doesn't support bounds likeChip<...>: for<'a> for<SC> Air<ConstraintFolder<'a, M, SC>>.)