Fix updated linters errors #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently new version of isort started failing on our codebase because it expects the import to be formatted in a different way. This commit is just a result of running `isort .` in the repo root. Signed-off-by: Mikhail Koviazin <[email protected]>
Flynt started erroring out the old-style formatting. Let's fix it. Signed-off-by: Mikhail Koviazin <[email protected]>
New version of black formatter started forcefully changing hexadecimal representation of bytes to lowercase. Let's fix it in the codebase. Signed-off-by: Mikhail Koviazin <[email protected]>
The tests expected exactly "88.05060698409301" as Valkey georadius result. However, on ARM64 machine the actual result is "88.05060698338646". The difference is roughly 7e-10 and is not caused by valkey-py, but rather a floating point error in georadius calculations inside Valkey. This commit allows such an error to happen without failing the test. Signed-off-by: Mikhail Koviazin <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #172 +/- ##
==========================================
- Coverage 76.26% 76.26% -0.01%
==========================================
Files 130 130
Lines 33956 33964 +8
==========================================
+ Hits 25897 25901 +4
- Misses 8059 8063 +4 ☔ View full report in Codecov by Sentry. |
bogdanp05
approved these changes
Feb 5, 2025
|
I'll create a ticket to consider using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request check-list
Description of change
This PR contains 4 commits: