Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Fix error command in the developer document #51

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

FawenYo
Copy link

@FawenYo FawenYo commented Feb 27, 2025

This PR is to fix the error command in the DEVELOPER.md.

@murphyjacob4
Copy link
Collaborator

For the DCO - would you take a look at https://github.com/valkey-io/valkey/blob/unstable/CONTRIBUTING.md#developer-certificate-of-origin and add

Signed-off-by: Jane Smith <[email protected]>

To the last line of the commit message? Thanks!

@FawenYo FawenYo force-pushed the doc/fix_bazel_build_config branch from d4780f4 to 3ce3840 Compare March 3, 2025 08:50
@FawenYo
Copy link
Author

FawenYo commented Mar 3, 2025

Hi @murphyjacob4, I've used amend with --signoff and force-pushed the new commit. Please help to check that, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants