Add Ayatana AppIndicator support #75
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for Ayatana AppIndicator in
cbatticon. This enhancement addresses a specific issue where GtkIcon tray apps are not displayed in some scenarios (e.g., with Waybar; see #74 for details).This PR does not replace GtkIcon but provides the option to choose between Ayatana AppIndicator (enabled with
WITH_APPINDICATOR) and GtkIcon through preprocessors. This approach is similar to how LIBNOTIFY is currently handled.However, there is a known limitation with Ayatana AppIndicator: it does not support click events (see AyatanaIndicators/libayatana-appindicator#4), required for left-click functionality. To work around this, the current implementation take advantage of the fact that a menu is necessary to have an indicator in ayatana, so I decided to use it to display those actions, this as a temporary measure until Ayatana adds support for click events.
