Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2024 10 23 bug changes #23

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Conversation

brendanreardon
Copy link
Collaborator

@brendanreardon brendanreardon commented Oct 23, 2024

This pull request contains bug fixes to bugs observed within release 0.7.1. The patch version of this code base was increased, now 0.7.2.

Bug fixes:

  • moalmanac.py would attempt to access the value "preclinical" in the preclinical_db_paths dictionary, even if no .ini file was provided using the --preclinical-dbs argument.

Revisions:

  • Patch number for this code base was increased to 0.7.2.
  • The section headers for both annotation-databases.ini and preclinical-databases.ini were named to paths.
  • Added documentation to the logging section of config.ini to reference the logging module documentation on docs.python.org.
  • run_example.py and moalmanac.py were both refactored with the order of how config_ini, dbs, and preclinical_dbs are set up before executing the main function. Instead of defining paths all at once and then importing each of them, each is processed on its own before moving to the next.
  • Minor PEP8 changes to logger.py and moalmanac.py, involving new line breaks or spacing.

Pre-pull request check list,

  • Relevant documentation has been updated
  • All unit tests pass
  • All outputs pre- and post- changes match by md5 hash
  • All files changed have been reviewed

@brendanreardon
Copy link
Collaborator Author

brendanreardon commented Oct 23, 2024

Bugs observed,

  • Failing at report generation if run directly from moalmanac.py if no input data is provided
  • Failing if preclinical-dbs is not provided and run directly from moalmanac.py

….ini to just be paths so that they are the same. moalmanac.py and run_example.py were refactored to just pass just the dictionary. Bug: There was a bug in moalmanac.py where the main function was being called and passing preclinical_db_paths['preclinical'] all the time, even if no .ini was passed. This was changed to only pass the dictionary to the main function, and sorting the indexing within the dictionary beforehand.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant