Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements to types #30

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Improvements to types #30

merged 5 commits into from
Oct 10, 2023

Conversation

lukasz-migas
Copy link
Member

Description

Related Issue

Type of Change

  • 📚 Examples / docs / tutorials / dependencies update
  • 🔧 Bug fix (non-breaking change which fixes an issue)
  • 🥂 Improvement (non-breaking change which improves an existing feature)
  • 🚀 New feature (non-breaking change which adds functionality)
  • 💥 Breaking change (fix or feature that would cause existing functionality to change)
  • 🔐 Security fix

Checklist

  • I've read the CODE_OF_CONDUCT.md document.
  • I've read the CONTRIBUTING.md guide.
  • I've updated the code style using make codestyle.
  • I've written tests for all new methods and classes that I created.
  • I've written the docstring in Google format for all the methods and classes that I used.

@codecov
Copy link

codecov bot commented Oct 4, 2023

Codecov Report

Merging #30 (7b77b1e) into main (62b4b3b) will decrease coverage by 0.34%.
Report is 6 commits behind head on main.
The diff coverage is 87.44%.

@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   71.23%   70.90%   -0.34%     
==========================================
  Files          18       18              
  Lines        1502     1526      +24     
==========================================
+ Hits         1070     1082      +12     
- Misses        432      444      +12     
Files Coverage Δ
src/imzy/_readers/bruker/utilities.py 21.73% <100.00%> (+3.55%) ⬆️
src/imzy/_readers/imzml/_ontology.py 35.29% <100.00%> (+1.29%) ⬆️
src/imzy/hookspec.py 88.88% <100.00%> (ø)
src/imzy/_extract.py 93.00% <86.66%> (-1.24%) ⬇️
src/imzy/_readers/bruker/_mixin.py 88.75% <93.10%> (-0.53%) ⬇️
src/imzy/_readers/_base.py 82.94% <87.50%> (-0.62%) ⬇️
src/imzy/_readers/imzml/_imzml.py 57.79% <84.84%> (-0.12%) ⬇️
src/imzy/_readers/bruker/_tsf.py 76.23% <83.33%> (-0.77%) ⬇️
src/imzy/_readers/bruker/_tdf.py 86.87% <86.95%> (-0.55%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lukasz-migas lukasz-migas merged commit 6e8e162 into main Oct 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant