Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve preloader #163

Closed
wants to merge 2 commits into from
Closed

Conversation

VidhanThakur09
Copy link
Contributor

Related Issue

Issue Fixed: #160

Description

Styling has been applied to the preloader. The preloader is present on all pages of the website with styling.

Improvements:

  1. Optimized Preloader: Enhanced the preloader animation on all pages to improve user experience.

  2. Revamped Preloader Design: Redesigned the preloader with modern CSS styling to enhance visual appeal.

  3. Dedicated Preloader StyleSheet: Created a separate CSS file named " preloaderStyle.css" to enhance the styling and functionality, ensuring better code organization and maintainability.

How Has This Been Tested?

The program was tested locally on a machine using the Chrome browser. To verify the changes, the website was loaded after the modifications were made. This involved manually inspecting the visual elements and functionally testing various user interactions to ensure the changes were implemented correctly.

Screenshots 📷

Before changes

Screenshot 2024-10-08 125957

After adding preloader

Screen.Recording.2024-10-08.195450.mp4

Copy link

Thank you for submitting your chaotic pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

Copy link

vercel bot commented Oct 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
chaos-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 22, 2024 2:25pm

@VidhanThakur09
Copy link
Contributor Author

VidhanThakur09 commented Oct 22, 2024

@vansh-codes could u please increase the level of this PR to level 3
and please merge this before someone edit the codebase

@vansh-codes
Copy link
Owner

Resolve the conflicts

@vansh-codes vansh-codes added the conflicts PR has merge conflicts label Oct 22, 2024
@VidhanThakur09
Copy link
Contributor Author

@vansh-codes all the conflicts has been resolved

issue no - #160

@vansh-codes vansh-codes self-requested a review October 22, 2024 20:01
@vansh-codes
Copy link
Owner

Hey @VidhanThakur09
I just checked your work, you have just copy pasted the code from html file to react file and nothing else
It doesnt works like that
Also the preloader is not visible, there is some logic to make it visible when loading, and modifying the index.html is not at all a good practice
I cant merge this PR, you can either make the required changes and then let me know or else close this PR and issue as well

@vansh-codes vansh-codes added invalid This doesn't seem right pending updates/changes pending labels Oct 22, 2024
Copy link
Owner

@vansh-codes vansh-codes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs to be fixed as said or else the PR will be closed

@VidhanThakur09
Copy link
Contributor Author

I will try to resolve the issue.

@vansh-codes
Copy link
Owner

Okay then resolve them and then let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflicts PR has merge conflicts invalid This doesn't seem right pending updates/changes pending
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CHAOS REPORT: Fixing Preloader
2 participants