Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rendered favicon and images properly #73

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Conversation

T-Fathima
Copy link
Contributor

Overview

This pull request fixes image rendering issues and resolves two related issues #71 and #72

Changes:

  • Corrected the relative path for the favicon and ChaosWeb SVG logo in the HTML file.
  • Ensured the assets are loading properly by adjusting the pathing for the images.
  • Cleared the browser cache to verify the fixes.

@vansh-codes Please review and merge.
Also Please assign gssoc-ext and hacktoberfest labels along with levels.

Screenshots:

image

Notes:

  • Both my issues were fixed in this single PR since they were related to asset pathing.

Copy link

Thank you for submitting your chaotic pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our chaotic CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@vansh-codes
Copy link
Owner

remove the red border and commit

@T-Fathima
Copy link
Contributor Author

Changes done
@vansh-codes You can check now.
image

@vansh-codes vansh-codes added bug Something isn't working gssoc-ext GSSOC'24 Extd Participant level1 awards 10 points hacktoberfest hacktoberfest registered hacktoberfest-accepted hacktoberfest accepted labels Oct 10, 2024
@vansh-codes vansh-codes merged commit f522a40 into vansh-codes:main Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working gssoc-ext GSSOC'24 Extd Participant hacktoberfest hacktoberfest registered hacktoberfest-accepted hacktoberfest accepted level1 awards 10 points
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants