fix(ripple): _ripple may be null in nuxt and add comment

varletjs · Feb 5, 2024 · 77c4ddc · 77c4ddc
1 parent 6f72b75
commit 77c4ddc
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 0 deletions.
diff --git a/packages/varlet-ui/src/back-top/BackTop.vue b/packages/varlet-ui/src/back-top/BackTop.vue
@@ -81,6 +81,7 @@ export default defineComponent({
 
     function removeScrollerEventListener() {
       if (!scroller) {
+        // may be null in nuxt
         return
       }
 

diff --git a/packages/varlet-ui/src/index-bar/IndexBar.vue b/packages/varlet-ui/src/index-bar/IndexBar.vue
@@ -174,6 +174,7 @@ export default defineComponent({
 
     function removeScrollerListener() {
       if (!scroller) {
+        // may be null in nuxt
         return
       }
 

diff --git a/packages/varlet-ui/src/list/List.vue b/packages/varlet-ui/src/list/List.vue
@@ -85,6 +85,7 @@ export default defineComponent({
 
     function removeScrollerListener() {
       if (!scroller) {
+        // may be null in nuxt
         return
       }
 

diff --git a/packages/varlet-ui/src/ripple/index.ts b/packages/varlet-ui/src/ripple/index.ts
@@ -143,6 +143,12 @@ function unmounted(el: RippleHTMLElement) {
   el.removeEventListener('touchstart', createRipple)
   el.removeEventListener('touchmove', forbidRippleTask)
   el.removeEventListener('dragstart', removeRipple)
+
+  if (!el._ripple || !el._ripple.removeRipple) {
+    // may be null in nuxt
+    return
+  }
+
   document.removeEventListener('touchend', el._ripple!.removeRipple)
   document.removeEventListener('touchcancel', el._ripple!.removeRipple)
   document.removeEventListener('dragend', el._ripple!.removeRipple)

diff --git a/packages/varlet-ui/src/sticky/Sticky.vue b/packages/varlet-ui/src/sticky/Sticky.vue
@@ -137,6 +137,7 @@ export default defineComponent({
 
     function removeScrollListener() {
       if (!scroller || scroller === window) {
+        // may be null in nuxt
         return
       }