Fix #49. Prevent buffer geometry mem leak in tiles and hex polygons data

vasturiano · Feb 28, 2022 · 87c301b · 87c301b
1 parent 638f4fa
commit 87c301b
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 0 deletions.
diff --git a/src/layers/hexedPolygons.js b/src/layers/hexedPolygons.js
@@ -121,6 +121,7 @@ export default Kapsule({
         const applyUpdate = td => {
           const { alt, margin, curvatureResolution } = obj.__currentTargetD = td;
 
+          obj.geometry && obj.geometry.dispose();
           obj.geometry = !hexBins.length
             ? new THREE.BufferGeometry()
             : BufferGeometryUtils.mergeBufferGeometries(hexBins.map(h => {

diff --git a/src/layers/tiles.js b/src/layers/tiles.js
@@ -78,6 +78,7 @@ export default Kapsule({
           const rotLng = deg2Rad(lng);
           const rotLat = deg2Rad(-lat);
 
+          obj.geometry && obj.geometry.dispose();
           obj.geometry = new THREE.SphereBufferGeometry(
             GLOBE_RADIUS * (1 + alt),
             Math.ceil(width / (curvatureResolution || -1)),