Fix build errors with latest bpf_conformance update #544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also filed Alan-Jowett/bpf_conformance#162 to get bpf_conformance updated so the add_subdirectory would not be needed after that is fixed. |
The elfio subdirectory addition is due to a change in bpf_conformance The execute_progress line change is because a build error has been there since vbpf#519 where https://github.com/vbpf/ebpf-verifier/actions/runs/6275811448/job/17044135123 for example shows (starting at line 27 in the log): Unknown command: 'ARGS' NuGet.Commands.CommandException: Unknown command: 'ARGS' at NuGet.CommandLine.CommandManager.GetCommand(String commandName) at NuGet.CommandLine.CommandLineParser.ParseCommandLine(IEnumerable`1 commandLineArgs) at NuGet.CommandLine.Program.MainCore(String workingDirectory, String[] args) Feeds used: https://api.nuget.org/v3/index.json C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\ [execute_process](https://cmake.org/cmake/help/latest/command/execute_process.html) should not have ARGS whereas [exec_program](https://cmake.org/cmake/help/latest/command/exec_program.html) does. Signed-off-by: Dave Thaler <[email protected]>
dthaler
force-pushed
the
dependabot/submodules/external/bpf_conformance-ab34094
branch
from
38c660f
to
9416ef5
Compare
elazarg
merged commit e486a9c
into
vbpf:dependabot/submodules/external/bpf_conformance-ab34094
5 checks passed
dthaler
added a commit
to dthaler/ebpf-verifier
that referenced
this pull request
Dec 25, 2023
This PR combines vbpf#543 and vbpf#544 Also removes a redundant inclusion of the elfio library Signed-off-by: Dave Thaler <[email protected]>
elazarg
pushed a commit
that referenced
this pull request
Dec 26, 2023
This PR combines #543 and #544 Also removes a redundant inclusion of the elfio library Signed-off-by: Dave Thaler <[email protected]>
Alan-Jowett
pushed a commit
to Alan-Jowett/ebpf-verifier
that referenced
this pull request
Oct 15, 2024
Signed-off-by: Will Hawkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does what dependabot tried to do in #543 but fixes the build errors that PR encountered.
The elfio line added is due to a dependency change inside bpf_conformance where src depends on elfio.
The execute_process line change is because a build error has been there since #519 where https://github.com/vbpf/ebpf-verifier/actions/runs/6275811448/job/17044135123 for example shows (starting at line 27 in the log):
Unknown command: 'ARGS'
NuGet.Commands.CommandException: Unknown command: 'ARGS'
at NuGet.CommandLine.CommandManager.GetCommand(String commandName)
at NuGet.CommandLine.CommandLineParser.ParseCommandLine(IEnumerable`1 commandLineArgs)
at NuGet.CommandLine.Program.MainCore(String workingDirectory, String[] args)
Feeds used:
https://api.nuget.org/v3/index.json
C:\Program Files (x86)\Microsoft SDKs\NuGetPackages\
execute_process should not have ARGS whereas
exec_program does.
Once this PR is merged into #543 then the checks for that PR should pass, allowing it to be merged.