forked from sagemath/sage
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
sagemathgh-39597: extract _front_back_facets method out of _tikz_3d_i…
…n_3d polyhedron method The code of the method `_tikz_3d_in_3d` is long. Also, the front and back facets it computes for the projection of a polyhedron is interesting by itself. Personally, I need this information in order to define a polyhedron exchange transformation out of the projection of a zonotope. In this PR, we extract a `_front_back_facets` method out of the `_tikz_3d_in_3d` method in the class Projection of a polyhedron. Meanwhile, we also improve the SageMath/Python code. For instance: ```diff - for index_facet in range(len(facets)): - A = facets[index_facet].vector()[1:] + for index_facet,f in enumerate(facet_ineqs): + A = f.A() ``` This was done during Sage Days 128 with Jean-Philippe Labbé. ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. URL: sagemath#39597 Reported by: Sébastien Labbé Reviewer(s): Frédéric Chapoton, Sébastien Labbé
- Loading branch information
Showing
1 changed file
with
56 additions
and
28 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters