Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid parental rating dialogs on some CAMs #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

M-Reimer
Copy link
Member

This change was originally made by @ciminus. As this VDR plugin is now "community maintained" (meaning there is no single person who actively maintains it) and, so far, I don't really understand what this change is for, I decided to put it into a Pull Request so this information is not lost and some discussion around it can happen here.

What I've found out, so far, is that this change may be related to parental rating dialogs popping up on the VDR server if a client requests such channels. This would mean someone has to walk to the server and somehow interact with this message. Good luck for a headless VDR server which probably displays this message into "nothing".

  • Is this a change everyone wants to have or should this have a configuration switch in the plugin settings?
  • What is this magic number "18" about? Where does it come from? Can this be placed to a constant or #define? I'm not a big fan of some unnamed magic numbers in code.
  • Oh, and why is it no option to just go to the CAM configuration and disable parental rating there?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants