Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deps #34

Merged
merged 1 commit into from
Feb 20, 2024
Merged

Update deps #34

merged 1 commit into from
Feb 20, 2024

Conversation

vearutop
Copy link
Owner

No description provided.

Copy link

Lines Of Code

Language Files Lines Code Comments Blanks Complexity Bytes
Go 16 (-1) 2014 (-12) 1577 (-6) 63 (-2) 374 (-4) 271 52.3K (-211B)
YAML 8 595 (+2) 499 (+2) 43 53 0 20K (+129B)

Copy link

Go API Changes

# github.com/vearutop/plt/nethttp
## incompatible changes
HTTP3Available: value changed from false to true

# summary
Inferred base version: v0.3.10
Suggested version: v0.4.0

Copy link

Unit Test Coverage

total: (statements) 42.7%
changed lines: (statements) 0.0%, coverage is less than 90.0%, consider testing the changes more thoroughly

Coverage of changed lines
File Function Coverage
Total 0.0%
s3/job.go 0.0%
s3/job.go:72 WriteAt 0.0%
nethttp/http3_go1.20.go no coverage
Coverage diff with base branch
File Function Base Coverage Current Coverage
Total 42.7% 42.7% (0.0%)
nethttp/http3.go makeTransport3 no function 0.0%
nethttp/http3_go1.21.go makeTransport3 0.0% no function

Copy link

Benchmark Result

Benchmark diff with base branch
name               old time/op    new time/op    delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4    13.6µs ± 1%    13.4µs ± 1%  -1.62%  (p=0.009 n=6+6)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4    1.00ms ± 0%    1.00ms ± 0%    ~     (p=0.937 n=6+6)

name               old alloc/op   new alloc/op   delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4    1.86kB ± 0%    1.86kB ± 0%    ~     (p=0.264 n=6+6)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4    5.90kB ± 1%    5.89kB ± 1%    ~     (p=0.699 n=6+6)

name               old allocs/op  new allocs/op  delta
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4      25.0 ± 0%      25.0 ± 0%    ~     (all equal)
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4      84.5 ± 1%      84.0 ± 0%    ~     (p=0.121 n=6+5)
Benchmark result
name               time/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4  13.4µs ± 1%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4  1.00ms ± 0%

name               alloc/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4  1.86kB ± 0%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4  5.89kB ± 1%

name               allocs/op
pkg:github.com/vearutop/plt/fasthttp goos:linux goarch:amd64
JobProducer_Job-4    25.0 ± 0%
pkg:github.com/vearutop/plt/nethttp goos:linux goarch:amd64
JobProducer_Job-4    84.0 ± 0%

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c887386) 48.00% compared to head (ea9ca9f) 35.86%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff             @@
##           master      #34       +/-   ##
===========================================
- Coverage   48.00%   35.86%   -12.14%     
===========================================
  Files           8       11        +3     
  Lines         600      803      +203     
===========================================
  Hits          288      288               
- Misses        270      473      +203     
  Partials       42       42               
Flag Coverage Δ
unittests 35.86% <ø> (-12.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vearutop vearutop merged commit 4ab54ab into master Feb 20, 2024
9 of 10 checks passed
@vearutop vearutop deleted the upd-deps-2 branch February 20, 2024 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants