Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing base fee + hard fork logic #933

Draft
wants to merge 37 commits into
base: release/galactica
Choose a base branch
from

Conversation

paologalligit
Copy link
Member

Description

This PR is introducing a new field called BaseFee. This is included in the block's header and fixes the gas threshold a tx must have to be included in the block.

GH-Issue

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@paologalligit paologalligit requested a review from a team as a code owner January 7, 2025 10:04
@paologalligit paologalligit marked this pull request as draft January 7, 2025 10:04
vm/chain_config.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2025

Codecov Report

Attention: Patch coverage is 72.02680% with 167 lines in your changes missing coverage. Please review.

Please upload report for BASE (release/galactica@effd7f5). Learn more about missing BASE report.

Files with missing lines Patch % Lines
tx/transaction.go 42.85% 96 Missing and 4 partials ⚠️
tx/tx_dynamic_fee.go 83.33% 9 Missing and 2 partials ⚠️
block/extension.go 66.66% 6 Missing and 4 partials ⚠️
tx/hashing.go 10.00% 9 Missing ⚠️
block/header.go 38.46% 6 Missing and 2 partials ⚠️
consensus/fork/galactica.go 87.93% 5 Missing and 2 partials ⚠️
consensus/validator.go 82.60% 4 Missing ⚠️
tx/builder.go 93.10% 4 Missing ⚠️
cmd/thor/solo/solo.go 40.00% 2 Missing and 1 partial ⚠️
tx/tx_legacy.go 94.73% 3 Missing ⚠️
... and 5 more
Additional details and impacted files
@@                 Coverage Diff                  @@
##             release/galactica     #933   +/-   ##
====================================================
  Coverage                     ?   61.11%           
====================================================
  Files                        ?      225           
  Lines                        ?    23937           
  Branches                     ?        0           
====================================================
  Hits                         ?    14628           
  Misses                       ?     8135           
  Partials                     ?     1174           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paologalligit paologalligit changed the base branch from feat/typed-tx to release/galactica January 14, 2025 11:06
@paologalligit paologalligit marked this pull request as draft January 14, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants