-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/fee logic #969
Merged
Merged
Feat/fee logic #969
+1,897
−392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59565b5
to
b103881
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## release/galactica #969 +/- ##
=====================================================
+ Coverage 62.03% 62.13% +0.09%
=====================================================
Files 225 226 +1
Lines 23350 23498 +148
=====================================================
+ Hits 14486 14601 +115
- Misses 7738 7763 +25
- Partials 1126 1134 +8 ☔ View full report in Codecov by Sentry. |
otherview
reviewed
Feb 3, 2025
72f9340
to
6205c3b
Compare
e082285
to
50fb433
Compare
otherview
previously approved these changes
Feb 12, 2025
0bb5df0
to
7751866
Compare
The base branch was changed.
a9aaf78
to
203f0df
Compare
otherview
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the logic to calculate the fees dynamically based on the VIP-Dynamic Fee Market.
GHIssue
Type of change
Please delete options that are not relevant.
Checklist: