Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typed receipts #986

Merged
merged 2 commits into from
Feb 21, 2025
Merged

Typed receipts #986

merged 2 commits into from
Feb 21, 2025

Conversation

paologalligit
Copy link
Member

Description

This PR introduces types for receipts based on their transaction's type

GHIssue

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • New and existing E2E tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have not added any vulnerable dependencies to my code

@codecov-commenter
Copy link

codecov-commenter commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 74.46809% with 36 lines in your changes missing coverage. Please review.

Project coverage is 62.17%. Comparing base (1b887cd) to head (d4143c8).

Files with missing lines Patch % Lines
tx/receipt.go 70.70% 22 Missing and 7 partials ⚠️
cmd/thor/utils.go 0.00% 4 Missing ⚠️
tx/transaction.go 60.00% 2 Missing ⚠️
api/blocks/types.go 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##           release/galactica     #986      +/-   ##
=====================================================
+ Coverage              62.14%   62.17%   +0.03%     
=====================================================
  Files                    226      226              
  Lines                  23498    23609     +111     
=====================================================
+ Hits                   14603    14680      +77     
- Misses                  7761     7788      +27     
- Partials                1134     1141       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@paologalligit paologalligit marked this pull request as ready for review February 21, 2025 11:24
@paologalligit paologalligit requested a review from a team as a code owner February 21, 2025 11:24
Copy link
Member

@otherview otherview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@paologalligit paologalligit merged commit 9c3100c into release/galactica Feb 21, 2025
14 checks passed
@paologalligit paologalligit deleted the feat/typed-receipts branch February 21, 2025 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants