Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datadog_traces) align max payload size with DD agent #18011

Closed
wants to merge 1 commit into from

Conversation

s-maj
Copy link

@s-maj s-maj commented Jul 18, 2023

Based on the change in the Datadog Agent, the current default limit is 25MB instead of 3.2MB defined currently in the Datadog Traces sink. Bumping the limit might help with the issue 14244 too.

@s-maj s-maj requested a review from a team July 18, 2023 09:48
@bits-bot
Copy link

bits-bot commented Jul 18, 2023

CLA assistant check
All committers have signed the CLA.

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for vrl-playground canceled.

Name Link
🔨 Latest commit 9a03d0a
🔍 Latest deploy log https://app.netlify.com/sites/vrl-playground/deploys/64b660b4eaf755000840f6c2

@netlify
Copy link

netlify bot commented Jul 18, 2023

Deploy Preview for vector-project canceled.

Name Link
🔨 Latest commit 9a03d0a
🔍 Latest deploy log https://app.netlify.com/sites/vector-project/deploys/64b660b41a8b830008942c2f

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Jul 18, 2023
@neuronull
Copy link
Contributor

Based on the change in the Datadog Agent, the current default limit is 25MB instead of 3.2MB defined currently in the Datadog Traces sink. Bumping the limit might help with the issue 14244 too.

👋 hello @s-maj , thanks for this suggestion.

I went a head and tried this locally sending a large trace - but the datadog_traces sink received a 413 error code.

Did you try this out yourself and I might be missing something?

It kind of reads like DataDog/datadog-agent#14782 is actually modifying the intake of traces into the trace agent , as opposed to the output. (Though, I do recognize that PR references it trying to more closely align with the DD backend, which would suggest that the backend could accept a payload larger than 3 MB).

@s-maj
Copy link
Author

s-maj commented Jul 20, 2023

Yeah, looks like I didn't test it right. I've looked at DD agent code again and it seems the total payload going to the backend is indeed 3.2MB but the Agent can ingest much bugger payloads.

EDIT for posterity:
Chunking itself happens here and subsequently here.

@s-maj s-maj closed this Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants