Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Migrate LogSchema::message_key to new lookup code #18024

Merged
merged 10 commits into from
Jul 21, 2023
Merged

feat: Migrate LogSchema::message_key to new lookup code #18024

merged 10 commits into from
Jul 21, 2023

Commits on Jul 21, 2023

  1. Migrate LogSchema::message_key to new lookup code

    @pront
    pront committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    5f92fbc View commit details
    Browse the repository at this point in the history

  2. Fix failing tests and also extract duplicate code in kubernetes_logs … 

    …into a util
    @pront
    pront committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    06d7649 View commit details
    Browse the repository at this point in the history

  3. adress Spencer's comments

    @pront
    pront committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    987c6ab View commit details
    Browse the repository at this point in the history

  4. nit: remove the need for {}

    @pront
    pront committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    218cc7f View commit details
    Browse the repository at this point in the history

  5. small helper for serializer schema_requirement

    @pront
    pront committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    d96b9df View commit details
    Browse the repository at this point in the history

  6. add maybe_insert and save a few lines

    @pront
    pront committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    af300eb View commit details
    Browse the repository at this point in the history

  7. docker_logs/mod.rs: replace 'unwrap()'s with 'expect()'s

    @pront
    pront committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    c5fbecc View commit details
    Browse the repository at this point in the history

  8. use Vec::new

    @pront
    pront committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    75f2309 View commit details
    Browse the repository at this point in the history

  9. avoid expensive to_string() calls, now using 'get_message()'

    @pront
    pront committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    20a996f View commit details
    Browse the repository at this point in the history

  10. add string constants in LogSchema

    @pront
    pront committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    53df423 View commit details
    Browse the repository at this point in the history