Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Handle recent GitHub Actions deprecations #21528

Merged
merged 2 commits into from
Oct 18, 2024

Conversation

jszwedko
Copy link
Member

Ref: https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/

As part of this, I changed the MacOS package verification to test on all available runner versions.

Ref: https://github.blog/changelog/2024-08-19-notice-of-upcoming-deprecations-and-breaking-changes-in-github-actions-runners/

As part of this, I changed the MacOS package verification to test on all available runner versions.

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 16, 2024
@jszwedko jszwedko requested a review from a team as a code owner October 16, 2024 20:07
@jszwedko
Copy link
Member Author

I kicked off the publish workflow to verify this still works: https://github.com/vectordotdev/vector/actions/runs/11374990836

@jszwedko jszwedko added this pull request to the merge queue Oct 17, 2024
@jszwedko jszwedko removed this pull request from the merge queue due to a manual request Oct 17, 2024
```
/Users/runner/work/_temp/76b64f87-2009-42f1-a94b-9416bb00e145.sh: line 1:
vector-x86_64-apple-darwin/bin/vector: Bad CPU type in executable
```

I spent some time trying to debug this but decided to punt on it for now.

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko requested a review from a team as a code owner October 18, 2024 14:25
@jszwedko jszwedko added this pull request to the merge queue Oct 18, 2024
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/handle-github-actions-deprecations
Commit report: 7ae59fd
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.49s Total Time

Copy link

Regression Detector Results

Run ID: bc9f731b-8389-40fb-bb0c-e68e1452d9cf Metrics dashboard

Baseline: f2d5ea4
Comparison: 624fa1a

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput -2.76 [-6.73, +1.21]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
datadog_agent_remap_blackhole ingress throughput +3.52 [+3.37, +3.67]
socket_to_socket_blackhole ingress throughput +2.65 [+2.56, +2.74]
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +1.70 [+1.61, +1.79]
syslog_log2metric_splunk_hec_metrics ingress throughput +1.45 [+1.29, +1.62]
syslog_loki ingress throughput +1.44 [+1.37, +1.52]
datadog_agent_remap_datadog_logs_acks ingress throughput +0.77 [+0.61, +0.93]
http_to_s3 ingress throughput +0.74 [+0.58, +0.89]
syslog_splunk_hec_logs ingress throughput +0.35 [+0.24, +0.47]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.00 [-0.02, +0.03]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.00 [-0.03, +0.02]
http_to_http_noack ingress throughput -0.00 [-0.06, +0.05]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.03, +0.02]
http_to_http_json ingress throughput -0.01 [-0.07, +0.04]
http_to_http_acks ingress throughput -0.06 [-0.55, +0.43]
fluent_elasticsearch ingress throughput -0.25 [-0.80, +0.29]
otlp_http_to_blackhole ingress throughput -0.28 [-0.36, -0.20]
http_text_to_http_json ingress throughput -0.61 [-0.74, -0.49]
splunk_hec_route_s3 ingress throughput -0.64 [-0.96, -0.32]
http_elasticsearch ingress throughput -0.93 [-1.06, -0.80]
syslog_regex_logs2metric_ddmetrics ingress throughput -1.05 [-1.23, -0.87]
datadog_agent_remap_datadog_logs ingress throughput -1.11 [-1.34, -0.87]
datadog_agent_remap_blackhole_acks ingress throughput -1.20 [-1.31, -1.09]
syslog_humio_logs ingress throughput -1.52 [-1.64, -1.40]
syslog_log2metric_humio_metrics ingress throughput -1.72 [-1.83, -1.61]
otlp_grpc_to_blackhole ingress throughput -2.05 [-2.24, -1.87]
file_to_blackhole egress throughput -2.76 [-6.73, +1.21]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 624fa1a Oct 18, 2024
51 checks passed
@jszwedko jszwedko deleted the jszwedko/handle-github-actions-deprecations branch October 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants