-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(sinks/gcp/pubsub.rs): remove pubsub log only restriction #21557
fix(sinks/gcp/pubsub.rs): remove pubsub log only restriction #21557
Conversation
272605c
to
7af135f
Compare
7af135f
to
d68beb0
Compare
/test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfect, thanks @genadipost ! I appreciate you adding a test.
I think the only thing this is missing is a changelog entry. Could you add one per https://github.com/vectordotdev/vector/blob/master/changelog.d/README.md ?
9fc3ad7
to
085791d
Compare
085791d
to
dd679f3
Compare
Done |
Perfect, thanks! |
Head branch was pushed to by a user without write access
@jszwedko I have fixed fmt issue. Can you enable the auto-merge again? :) |
Regression Detector ResultsRun ID: b1e62cca-02f7-4c68-b606-7a57bd11cfda Metrics dashboard Baseline: dd39ab3 Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | file_to_blackhole | egress throughput | +0.78 | [-3.45, +5.02] |
Fine details of change detection per experiment
perf | experiment | goal | Δ mean % | Δ mean % CI | links |
---|---|---|---|---|---|
➖ | syslog_humio_logs | ingress throughput | +1.56 | [+1.46, +1.67] | |
➖ | http_elasticsearch | ingress throughput | +1.24 | [+1.04, +1.44] | |
➖ | fluent_elasticsearch | ingress throughput | +0.83 | [+0.28, +1.37] | |
➖ | file_to_blackhole | egress throughput | +0.78 | [-3.45, +5.02] | |
➖ | syslog_splunk_hec_logs | ingress throughput | +0.72 | [+0.61, +0.82] | |
➖ | http_to_s3 | ingress throughput | +0.21 | [+0.05, +0.38] | |
➖ | datadog_agent_remap_datadog_logs_acks | ingress throughput | +0.13 | [-0.07, +0.33] | |
➖ | http_to_http_json | ingress throughput | +0.01 | [-0.04, +0.06] | |
➖ | splunk_hec_to_splunk_hec_logs_acks | ingress throughput | +0.00 | [-0.03, +0.03] | |
➖ | splunk_hec_to_splunk_hec_logs_noack | ingress throughput | -0.00 | [-0.02, +0.02] | |
➖ | http_to_http_noack | ingress throughput | -0.00 | [-0.06, +0.06] | |
➖ | splunk_hec_indexer_ack_blackhole | ingress throughput | -0.00 | [-0.02, +0.02] | |
➖ | http_to_http_acks | ingress throughput | -0.09 | [-0.58, +0.40] | |
➖ | datadog_agent_remap_blackhole_acks | ingress throughput | -0.11 | [-0.23, +0.00] | |
➖ | syslog_loki | ingress throughput | -0.18 | [-0.30, -0.06] | |
➖ | splunk_hec_route_s3 | ingress throughput | -0.21 | [-0.54, +0.11] | |
➖ | syslog_log2metric_tag_cardinality_limit_blackhole | ingress throughput | -0.23 | [-0.33, -0.14] | |
➖ | syslog_log2metric_splunk_hec_metrics | ingress throughput | -0.54 | [-0.68, -0.40] | |
➖ | syslog_log2metric_humio_metrics | ingress throughput | -0.56 | [-0.68, -0.44] | |
➖ | http_text_to_http_json | ingress throughput | -0.62 | [-0.73, -0.51] | |
➖ | datadog_agent_remap_datadog_logs | ingress throughput | -1.50 | [-1.70, -1.31] | |
➖ | datadog_agent_remap_blackhole | ingress throughput | -2.75 | [-2.84, -2.65] | |
➖ | otlp_http_to_blackhole | ingress throughput | -3.08 | [-3.16, -3.00] | |
➖ | otlp_grpc_to_blackhole | ingress throughput | -3.14 | [-3.30, -2.98] | |
➖ | syslog_regex_logs2metric_ddmetrics | ingress throughput | -3.52 | [-3.67, -3.37] | |
➖ | socket_to_socket_blackhole | ingress throughput | -3.71 | [-3.77, -3.64] |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
Inspired by #18074