Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Group together patch updates with dependabot #21595

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

jszwedko
Copy link
Member

Patch updates, per semvar, have a low risk of incompatibility and so I think they can all be grouped together. The changelogs should still be reviewed when merging, but this should reduce CI costs.

I was going to add minor here too, but for dependencies pre-1.0, minor updates can be breaking. There is a dependabot issue asking for this behavior to change: dependabot/dependabot-core#9647. Also some discussion about this on: dependabot/dependabot-core#7795

Patch updates, per semvar, have a low risk of incompatibility and so I think they can all be grouped
together.

I was going to add `minor` here too, but for dependencies pre-1.0, minor updates can be breaking.
There is a dependabot issue asking for this behavior to change:
dependabot/dependabot-core#9647. Also some discussion about this on:
dependabot/dependabot-core#7795

Signed-off-by: Jesse Szwedko <[email protected]>
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Oct 23, 2024
@jszwedko jszwedko requested a review from a team as a code owner October 23, 2024 15:50
@jszwedko jszwedko requested a review from pront October 23, 2024 15:50
@datadog-vectordotdev
Copy link

Datadog Report

Branch report: jszwedko/group-patches
Commit report: b3ed3ff
Test service: vector

✅ 0 Failed, 7 Passed, 0 Skipped, 25.45s Total Time

Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, it should reduce CI costs and KTLO burden 👍

@pront pront added this pull request to the merge queue Oct 23, 2024
Copy link

Regression Detector Results

Run ID: dfb02cef-a775-43c5-aa18-2fb7b452fb87 Metrics dashboard

Baseline: 4617145
Comparison: 776f4c6

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI links
file_to_blackhole egress throughput +0.66 [-3.41, +4.73]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI links
syslog_log2metric_tag_cardinality_limit_blackhole ingress throughput +1.23 [+1.13, +1.33]
syslog_log2metric_humio_metrics ingress throughput +1.21 [+1.06, +1.36]
syslog_regex_logs2metric_ddmetrics ingress throughput +1.13 [+0.95, +1.32]
fluent_elasticsearch ingress throughput +1.12 [+0.57, +1.67]
syslog_splunk_hec_logs ingress throughput +1.04 [+0.95, +1.12]
otlp_http_to_blackhole ingress throughput +0.77 [+0.69, +0.86]
syslog_humio_logs ingress throughput +0.76 [+0.63, +0.88]
datadog_agent_remap_blackhole ingress throughput +0.70 [+0.62, +0.79]
file_to_blackhole egress throughput +0.66 [-3.41, +4.73]
syslog_loki ingress throughput +0.54 [+0.45, +0.62]
splunk_hec_route_s3 ingress throughput +0.46 [+0.08, +0.83]
http_to_s3 ingress throughput +0.45 [+0.27, +0.62]
socket_to_socket_blackhole ingress throughput +0.41 [+0.35, +0.47]
datadog_agent_remap_datadog_logs ingress throughput +0.40 [+0.22, +0.58]
http_elasticsearch ingress throughput +0.37 [+0.21, +0.53]
datadog_agent_remap_blackhole_acks ingress throughput +0.04 [-0.05, +0.14]
http_to_http_acks ingress throughput +0.02 [-0.42, +0.46]
splunk_hec_to_splunk_hec_logs_acks ingress throughput +0.01 [-0.01, +0.04]
splunk_hec_to_splunk_hec_logs_noack ingress throughput -0.00 [-0.02, +0.02]
splunk_hec_indexer_ack_blackhole ingress throughput -0.00 [-0.02, +0.02]
http_to_http_json ingress throughput -0.00 [-0.05, +0.04]
http_to_http_noack ingress throughput -0.01 [-0.07, +0.05]
syslog_log2metric_splunk_hec_metrics ingress throughput -0.81 [-0.89, -0.73]
http_text_to_http_json ingress throughput -0.85 [-1.03, -0.68]
datadog_agent_remap_datadog_logs_acks ingress throughput -2.16 [-2.33, -1.98]
otlp_grpc_to_blackhole ingress throughput -2.81 [-2.99, -2.62]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Merged via the queue into master with commit 776f4c6 Oct 23, 2024
72 checks passed
@pront pront deleted the jszwedko/group-patches branch October 23, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants