fix(codecs): Fix gelf deserialization of subsecond timestamps #21613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #21610 Signed-off-by: Jesse Szwedko <[email protected]>
jszwedko
commented
Oct 24, 2024
Comment on lines
+210
to
+211
| #[serde_as(as = "Option<TimestampSecondsWithFrac<f64>>")] | ||
| timestamp: Option<DateTime<Utc>>, |
There was a problem hiding this comment.
I brought in serde_with for custom deserialization rather than doing floating point arithmetic to preserve the precision of the timestamps.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Jesse Szwedko <[email protected]>
pront
approved these changes
Oct 24, 2024
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.52s Total Time |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #21610