-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(codecs): Fix gelf deserialization of subsecond timestamps #21613
base: master
Are you sure you want to change the base?
Conversation
Fixes: #21610 Signed-off-by: Jesse Szwedko <[email protected]>
#[serde_as(as = "Option<TimestampSecondsWithFrac<f64>>")] | ||
timestamp: Option<DateTime<Utc>>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I brought in serde_with
for custom deserialization rather than doing floating point arithmetic to preserve the precision of the timestamps.
Signed-off-by: Jesse Szwedko <[email protected]>
Datadog ReportBranch report: ✅ 0 Failed, 7 Passed, 0 Skipped, 25.52s Total Time |
Fixes: #21610