-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(new sink): Keep sink #22072
base: master
Are you sure you want to change the base?
feat(new sink): Keep sink #22072
Conversation
@sainad2222 looks good!! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @sainad2222, can you add a changelong fragment?
Also, please take a look at this PR as an example on how to include this new sink to our website: https://github.com/vectordotdev/vector/pull/13007/files#diff-a0be14524a6e437c68388b393dbff417eceb1dd09857df9173b3e6f217f57376 You can start with the following:
|
2b4d26d
to
ae1e7c3
Compare
ae1e7c3
to
d142eae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this got modified. Let me know if it's not needed, I'll undo these manually
Change Type
Is this a breaking change?
How did you test this PR?
Vector config:
Does this PR include user facing changes?
Checklist
Cargo.lock
), pleaserun
dd-rust-license-tool write
to regenerate the license inventory and commit the changes (if any). More details here.References