Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new sink): Keep sink #22072

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

sainad2222
Copy link

@sainad2222 sainad2222 commented Dec 21, 2024

Change Type

  • Bug fix
  • New feature
  • Non-functional (chore, refactoring, docs)
  • Performance

Is this a breaking change?

  • Yes
  • No

How did you test this PR?

Vector config:

sources:
  prometheus:
    type: http
    address: 0.0.0.0:8686

sinks:
  keep:
    type: "keep"
    inputs: ["prometheus"]
    endpoint: "http://localhost:8080/alerts/event/vectordev?provider_id=test"
    api_key: "keepappkey"

Does this PR include user facing changes?

  • Yes. Please add a changelog fragment based on our guidelines.
  • No. A maintainer will apply the "no-changelog" label to this PR.

Checklist

  • Please read our Vector contributor resources.
  • If this PR introduces changes Vector dependencies (modifies Cargo.lock), please
    run dd-rust-license-tool write to regenerate the license inventory and commit the changes (if any). More details here.

References

@bits-bot
Copy link

bits-bot commented Dec 21, 2024

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the domain: sinks Anything related to the Vector's sinks label Dec 21, 2024
@talboren
Copy link

talboren commented Jan 3, 2025

@sainad2222 looks good!!

@pront pront marked this pull request as ready for review January 3, 2025 14:36
@pront pront requested a review from a team as a code owner January 3, 2025 14:36
Copy link
Member

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sainad2222, can you add a changelong fragment?

@pront
Copy link
Member

pront commented Jan 7, 2025

Also, please take a look at this PR as an example on how to include this new sink to our website: https://github.com/vectordotdev/vector/pull/13007/files#diff-a0be14524a6e437c68388b393dbff417eceb1dd09857df9173b3e6f217f57376

You can start with the following:

  • Run make generate-component-docs
  • Add a website/content/en/docs/reference/configuration/sinks/keep.md

@sainad2222 sainad2222 force-pushed the sainad2222/keep_sink branch from 2b4d26d to ae1e7c3 Compare January 11, 2025 10:59
@sainad2222 sainad2222 requested review from a team as code owners January 11, 2025 10:59
@github-actions github-actions bot added the domain: external docs Anything related to Vector's external, public documentation label Jan 11, 2025
@sainad2222 sainad2222 force-pushed the sainad2222/keep_sink branch from ae1e7c3 to d142eae Compare January 11, 2025 11:01
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this got modified. Let me know if it's not needed, I'll undo these manually

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
domain: external docs Anything related to Vector's external, public documentation domain: sinks Anything related to the Vector's sinks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Keep sink
4 participants