chore(sinks): fix endpoint strip for aws region #3070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kirill Fomichev <[email protected]>
fanatid
added
type: bug
Hoverbear
approved these changes
Jul 15, 2020
|
I'd like to get @bruceg's approval before merging this, just to make sure this doesn't regress a separate feature that we are not aware of. |
Signed-off-by: Kirill Fomichev <[email protected]>
bruceg
requested changes
Jul 15, 2020
There was a problem hiding this comment.
I agree with @lukesteensen, this needs a test case to demonstrate the issue, preferably handling all of:
- No trailing slash on URL,
- With a trailing slash,
- With trailing slash and path,
- Maybe all of the above with a query string.
I see I tested #1, and #3 with a query, but I obviously didn't check other cases.
|
Pushed test, but github not displayed new changes in branch.. |
Signed-off-by: Kirill Fomichev <[email protected]>
Merged
bruceg
approved these changes
Jul 15, 2020
|
Did... GA break? |
Signed-off-by: Ana Hobden <[email protected]>
mengesb
pushed a commit
to jacobbraaten/vector
that referenced
this pull request
Dec 9, 2020
* chore(sinks): fix endpoint strip for aws region Signed-off-by: Kirill Fomichev <[email protected]> * add test Signed-off-by: Kirill Fomichev <[email protected]> * add yet one test Signed-off-by: Kirill Fomichev <[email protected]> * Github actions is buggy Signed-off-by: Ana Hobden <[email protected]> Co-authored-by: Ana Hobden <[email protected]> Signed-off-by: Brian Menges <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3067
Introduced in #2489: https://github.com/timberio/vector/pull/2489/files#diff-9eda8574251e683f40cb5255b9709c13R74