fix(datadog search): remove Datadog logs intake event structure assumption #1003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruceg
force-pushed
the
bruceg/OPA-1753-fix-event-structure-assumption
branch
from
2324a9e
to
8d57211
Compare
bruceg
force-pushed
the
bruceg/OPA-1753-fix-event-structure-assumption
branch
from
8d57211
to
ae0469d
Compare
neuronull
approved these changes
Aug 23, 2024
src/datadog/search/field.rs
Outdated
Comment on lines
38
to
40
| // root level field "custom". In OPW/Vector we do not have this event | ||
| // structure so we are diverging a little from the DD Log Search | ||
| // definition and implementation a bit here, by calling this "Attribute". |
There was a problem hiding this comment.
Suggested change
| // root level field "custom". In OPW/Vector we do not have this event | |
| // structure so we are diverging a little from the DD Log Search | |
| // definition and implementation a bit here, by calling this "Attribute". | |
| // root level field "custom". In VRL we do not guarantee this event | |
| // structure so we are diverging a little from the DD Log Search | |
| // definition and implementation a bit here, by calling this "Attribute". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.