Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(datadog search): Allow use of QueryNode in configurations #1007

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

bruceg
Copy link
Member

@bruceg bruceg commented Aug 26, 2024

This adds support for serde serialization and deserialization for queries via their string representation, allowing them to be used directly in configurations without storing them in an intermediate String.

This adds support for serde serialization and deserialization for queries via
their string representation, allowing them to be used directly in configurations
without storing them in an intermediate `String`.
@bruceg bruceg added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label Aug 26, 2024
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there anything that would make sense to test here?

@bruceg
Copy link
Member Author

bruceg commented Aug 26, 2024

Good call, done in b840a8e

@bruceg bruceg requested a review from jszwedko August 26, 2024 14:54
@bruceg bruceg added this pull request to the merge queue Aug 26, 2024
Merged via the queue into main with commit f3a4ee3 Aug 26, 2024
14 checks passed
@bruceg bruceg deleted the bruceg/OPA-1753-datadog-serde branch August 26, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants