Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(vrl): always rebuilding because of build.rs #362

Merged
merged 2 commits into from
Aug 2, 2023
Merged

fix(vrl): always rebuilding because of build.rs #362

merged 2 commits into from
Aug 2, 2023

Conversation

Zettroke
Copy link
Contributor

@Zettroke Zettroke commented Aug 2, 2023

Hi, noticed that vrl crate was always rebuilding.

Found out the cargo:rerun-if-changed had wrong path. Fixed it.

@Zettroke Zettroke changed the title Fix always rebuilding vrl Fix always rebuilding because of build.rs Aug 2, 2023
@jszwedko jszwedko requested a review from pront August 2, 2023 15:09
pront
pront approved these changes Aug 2, 2023
View reviewed changes
Copy link
Contributor

@pront pront left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Zettroke!

@pront pront enabled auto-merge (squash) August 2, 2023 16:15
@pront pront merged commit e32d4ee into vectordotdev:main Aug 2, 2023
8 checks passed
@neuronull neuronull changed the title Fix always rebuilding because of build.rs fix(vrl): always rebuilding because of build.rs Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pront pront pront approved these changes

@mikhailzagurskiy mikhailzagurskiy mikhailzagurskiy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zettroke @pront @mikhailzagurskiy