-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deps): bump domain from 0.9.3 to 0.10.0 #831
chore(deps): bump domain from 0.9.3 to 0.10.0 #831
Conversation
Bumps [domain](https://github.com/nlnetlabs/domain) from 0.9.3 to 0.10.0. - [Release notes](https://github.com/nlnetlabs/domain/releases) - [Changelog](https://github.com/NLnetLabs/domain/blob/main/Changelog.md) - [Commits](NLnetLabs/domain@v0.9.3...v0.10.0) --- updated-dependencies: - dependency-name: domain dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]>
Replacement for #828 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @esensar
Neat, thanks! |
@esensar just a note that it looks like the tests need to be updated. You can run |
Head branch was pushed to by a user without write access
I have made a decision to remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @esensar !
I agree it could be useful to have an option to skip tests. For other functions that return dynamic values, we've used simpler assertions in the examples. For example, the Lines 18 to 24 in e05fee7
|
Oh, didn't think about doing it like that. That makes sense, although in this case I think this solution is fine for now. |
Closes: #828