Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): bump domain from 0.9.3 to 0.10.0 #831

Merged
merged 6 commits into from
May 10, 2024

Conversation

esensar
Copy link
Contributor

@esensar esensar commented May 7, 2024

Closes: #828

dependabot bot and others added 4 commits May 7, 2024 05:00
Bumps [domain](https://github.com/nlnetlabs/domain) from 0.9.3 to 0.10.0.
- [Release notes](https://github.com/nlnetlabs/domain/releases)
- [Changelog](https://github.com/NLnetLabs/domain/blob/main/Changelog.md)
- [Commits](NLnetLabs/domain@v0.9.3...v0.10.0)

---
updated-dependencies:
- dependency-name: domain
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@esensar
Copy link
Contributor Author

esensar commented May 7, 2024

Replacement for #828

Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @esensar

@jszwedko jszwedko enabled auto-merge May 7, 2024 18:20
@jszwedko jszwedko added the no-changelog Changes in this PR do not need user-facing explanations in the release changelog label May 7, 2024
@pront
Copy link
Contributor

pront commented May 7, 2024

Neat, thanks!

@jszwedko
Copy link
Member

jszwedko commented May 7, 2024

@esensar just a note that it looks like the tests need to be updated. You can run ./scripts/vrl_tests.sh locally to see the failure.

@esensar
Copy link
Contributor Author

esensar commented May 7, 2024

@esensar just a note that it looks like the tests need to be updated. You can run ./scripts/vrl_tests.sh locally to see the failure.

Yeah, it is the issue with examples that I mentioned in #828. Not sure how to resolve that, without just removing examples or id from result.

auto-merge was automatically disabled May 8, 2024 06:44

Head branch was pushed to by a user without write access

@esensar
Copy link
Contributor Author

esensar commented May 8, 2024

I have made a decision to remove id from header for now. I think it would be good to expand VRL example tests with an option to skip tests (but since Example is constructed directly, that would require change in all functions to add that extra skip parameter) and then we could add it back so that we can keep these examples with id in dns_lookup.

@esensar esensar requested a review from jszwedko May 10, 2024 08:55
Copy link
Member

@jszwedko jszwedko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @esensar !

@jszwedko
Copy link
Member

I agree it could be useful to have an option to skip tests. For other functions that return dynamic values, we've used simpler assertions in the examples. For example, the uuid_v4 example:

fn examples(&self) -> &'static [Example] {
&[Example {
title: "generate UUID v4",
source: r#"uuid_v4() != """#,
result: Ok("true"),
}]
}

@jszwedko jszwedko enabled auto-merge May 10, 2024 13:29
@jszwedko jszwedko added this pull request to the merge queue May 10, 2024
@esensar
Copy link
Contributor Author

esensar commented May 10, 2024

I agree it could be useful to have an option to skip tests. For other functions that return dynamic values, we've used simpler assertions in the examples. For example, the uuid_v4 example:

fn examples(&self) -> &'static [Example] {
&[Example {
title: "generate UUID v4",
source: r#"uuid_v4() != """#,
result: Ok("true"),
}]
}

Oh, didn't think about doing it like that. That makes sense, although in this case I think this solution is fine for now.

Merged via the queue into vectordotdev:main with commit 27784cd May 10, 2024
12 checks passed
@esensar esensar deleted the dependabot/cargo/domain-0.10.0 branch May 10, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Changes in this PR do not need user-facing explanations in the release changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants