New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

unconditionally assign lastAcceptanceDate #344

Open

MegaphoneJon wants to merge 1 commit into veda-consulting-company:master from MegaphoneJon:assign-acceptance-date

Contributor

MegaphoneJon commented May 14, 2024

In PHP 8, Smarty throws warnings if you attempt to access an unassigned variable. I've been seeing this in my logs:

Message 	Warning: Undefined array key "lastAcceptanceDate" in include() (line 8 of /tmp/civicrm/templates_c/en_US/%%27/271/2713A10B%%ContactSummary.tpl.php)

Since we're already assigning a value of NULL a few lines above, we should always be assigning that to Smarty instead of leaving it uninitialized.


          unconditionally assign lastAcceptanceDate

e5f5882

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet