Add SchemaBase as return type to from_dict

vega · Aug 10, 2023 · 2732c8f · 2732c8f
1 parent f83caa5
commit 2732c8f
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/altair/utils/schemapi.py b/altair/utils/schemapi.py
@@ -927,7 +927,7 @@ def from_dict(
         _wrapper_classes: Optional[Iterable[Type["SchemaBase"]]] = None,
         # Type hints for this method would get rather complicated
         # if we want to provide a more specific return type
-    ) -> Any:
+    ) -> "SchemaBase":
         """Construct class from a dictionary representation
 
         Parameters

diff --git a/altair/vegalite/v5/api.py b/altair/vegalite/v5/api.py
@@ -2592,7 +2592,7 @@ def _get_name(cls):
         return f"view_{cls._counter}"
 
     @classmethod
-    def from_dict(cls, dct, validate=True) -> "Chart":  # type: ignore[override]  # Not the same signature as SchemaBase.from_dict. Would ideally be aligned in the future
+    def from_dict(cls, dct, validate=True) -> core.SchemaBase:  # type: ignore[override]  # Not the same signature as SchemaBase.from_dict. Would ideally be aligned in the future
         """Construct class from a dictionary representation
 
         Parameters

diff --git a/tools/schemapi/schemapi.py b/tools/schemapi/schemapi.py
@@ -925,7 +925,7 @@ def from_dict(
         _wrapper_classes: Optional[Iterable[Type["SchemaBase"]]] = None,
         # Type hints for this method would get rather complicated
         # if we want to provide a more specific return type
-    ) -> Any:
+    ) -> "SchemaBase":
         """Construct class from a dictionary representation
 
         Parameters