feat: Adds ThemeConfig (TypedDict) (#3536)

Co-authored-by: Stefan Binder <[email protected]>
vega · Sep 22, 2024 · 712680b · 712680b
1 parent eb6febd
commit 712680b
Show file tree

Hide file tree

Showing 18 changed files with 10,121 additions and 772 deletions.
diff --git a/altair/typing.py → altair/typing/__init__.py b/altair/typing.py → altair/typing/__init__.py
@@ -46,9 +46,13 @@
     "ChartType",
     "EncodeKwds",
     "Optional",
+    "ThemeConfig",
     "is_chart_type",
+    "theme",
 ]
 
+from altair.typing import theme
+from altair.typing.theme import ThemeConfig
 from altair.utils.schemapi import Optional
 from altair.vegalite.v5.api import ChartType, is_chart_type
 from altair.vegalite.v5.schema.channels import (

diff --git a/altair/typing/theme.py b/altair/typing/theme.py
@@ -0,0 +1 @@
+from altair.vegalite.v5.schema._config import *  # noqa: F403
diff --git a/altair/utils/core.py b/altair/utils/core.py
@@ -771,9 +771,21 @@ def decorate(cb: WrapsFunc[R], /) -> WrappedMethod[T, P, R] | WrappedFunc[P, R]:
     return decorate
 
 
+@overload
 def update_nested(
     original: t.MutableMapping[Any, Any],
     update: t.Mapping[Any, Any],
+    copy: Literal[False] = ...,
+) -> t.MutableMapping[Any, Any]: ...
+@overload
+def update_nested(
+    original: t.Mapping[Any, Any],
+    update: t.Mapping[Any, Any],
+    copy: Literal[True],
+) -> t.MutableMapping[Any, Any]: ...
+def update_nested(
+    original: Any,
+    update: t.Mapping[Any, Any],
     copy: bool = False,
 ) -> t.MutableMapping[Any, Any]:
     """

diff --git a/altair/utils/theme.py b/altair/utils/theme.py
@@ -3,9 +3,10 @@
 from __future__ import annotations
 
 import sys
-from typing import TYPE_CHECKING, Any, Dict
+from typing import TYPE_CHECKING
 
-from .plugin_registry import Plugin, PluginRegistry
+from altair.utils.plugin_registry import Plugin, PluginRegistry
+from altair.vegalite.v5.schema._config import ThemeConfig
 
 if sys.version_info >= (3, 11):
     from typing import LiteralString
@@ -16,12 +17,12 @@
     from altair.utils.plugin_registry import PluginEnabler
     from altair.vegalite.v5.theme import AltairThemes, VegaThemes
 
-ThemeType = Plugin[Dict[str, Any]]
+ThemeType = Plugin[ThemeConfig]
 
 
 # HACK: See for `LiteralString` requirement in `name`
 # https://github.com/vega/altair/pull/3526#discussion_r1743350127
-class ThemeRegistry(PluginRegistry[ThemeType, Dict[str, Any]]):
+class ThemeRegistry(PluginRegistry[ThemeType, ThemeConfig]):
     def enable(
         self, name: LiteralString | AltairThemes | VegaThemes | None = None, **options
     ) -> PluginEnabler: