fix(typing): Add untyped vegafusion to mypy overrides (#3640)

vega · Oct 13, 2024 · bb46f81 · bb46f81
1 parent 2032036
commit bb46f81
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/altair/utils/_importers.py b/altair/utils/_importers.py
@@ -12,7 +12,7 @@
 def import_vegafusion() -> ModuleType:
     min_version = "1.5.0"
     try:
-        import vegafusion as vf  # type: ignore
+        import vegafusion as vf
 
         version = importlib_version("vegafusion")
         embed_version = importlib_version("vegafusion-python-embed")

diff --git a/altair/utils/_vegafusion_data.py b/altair/utils/_vegafusion_data.py
@@ -26,7 +26,7 @@
 if TYPE_CHECKING:
     from narwhals.typing import IntoDataFrame
 
-    from vegafusion.runtime import ChartState  # type: ignore
+    from vegafusion.runtime import ChartState
 
 # Temporary storage for dataframes that have been extracted
 # from charts by the vegafusion data transformer. Use a WeakValueDictionary

diff --git a/pyproject.toml b/pyproject.toml
@@ -436,6 +436,7 @@ module = [
     "nbformat.*",
     "ipykernel.*",
     "ibis.*",
+    "vegafusion.*",
     # This refers to schemapi in the tools folder which is imported
     # by the tools scripts such as generate_schema_wrapper.py
     # "schemapi.*"

diff --git a/tests/test_jupyter_chart.py b/tests/test_jupyter_chart.py
@@ -26,7 +26,7 @@
 
 
 try:
-    import vegafusion  # type: ignore # noqa: F401
+    import vegafusion  # noqa: F401
 
     transformers = ["default", "vegafusion"]
 except ImportError:

diff --git a/tests/test_transformed_data.py b/tests/test_transformed_data.py
@@ -10,7 +10,7 @@
 import narwhals as nw
 
 try:
-    import vegafusion as vf  # type: ignore
+    import vegafusion as vf
 except ImportError:
     vf = None