Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Restrict static & runtime top-level imports #3482

Merged
merged 24 commits into from
Jul 22, 2024
Merged

fix: Restrict static & runtime top-level imports #3482

merged 24 commits into from
Jul 22, 2024

Commits on Jul 16, 2024

  1. feat: generate an __all__ for channels.py 

    This missing is the main source of unpredictable imports.

I've explicitly not included the `Mixin` classes, side effect imports (e.g. `Undefined`, `parse_shorthand`, `@overload`) and `@with_property_setters`
    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2864c07 View commit details
    Browse the repository at this point in the history

  2. build: run generate-schema-wrapper

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2444f70 View commit details
    Browse the repository at this point in the history

  3. refactor: change the sources for some import in api

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    db31ff1 View commit details
    Browse the repository at this point in the history

  4. refactor: add explicit import for utils.parse_shorthand 

    This was the only side-effect import that I imagine was useful
    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    160ce60 View commit details
    Browse the repository at this point in the history

  5. build: run update-init-file

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    e21b8c8 View commit details
    Browse the repository at this point in the history

  6. chore(ruff): replace blanket noqa with specific rules

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    fac81d6 View commit details
    Browse the repository at this point in the history

  7. refactor: add explicit imports in v5.__init__.py 

    Previously imported in `api` -> here
    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    7e3c5bd View commit details
    Browse the repository at this point in the history

  8. feat: define an __all__ for api.py manually 

    Currently not included deprecations, but will probably have to revert later
    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    2c286b5 View commit details
    Browse the repository at this point in the history

  9. refactor: add explicit imports for Optional, Undefined

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    42cf5e8 View commit details
    Browse the repository at this point in the history

  10. build: run update-init-file 

    Dropped from top-level:
`DataType`, `TOPLEVEL_ONLY_KEYS`, `mixins`
    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    973dfc7 View commit details
    Browse the repository at this point in the history

  11. test: use explicit import for Undefined

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    38535a0 View commit details
    Browse the repository at this point in the history

  12. test: use explicit import for AltairDeprecationWarning

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    a85d77a View commit details
    Browse the repository at this point in the history

  13. fix: add deprecations to api.pys __all__

    @dangotbanned
    dangotbanned committed Jul 16, 2024
    Configuration menu
    Copy the full SHA
    b913cd8 View commit details
    Browse the repository at this point in the history

Commits on Jul 17, 2024

  1. Merge branch 'main' into fix-pylance-imports

    @dangotbanned
    dangotbanned committed Jul 17, 2024
    Configuration menu
    Copy the full SHA
    c956968 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Merge branch 'main' into fix-pylance-imports

    @dangotbanned
    dangotbanned committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    a7be727 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2024

  1. Merge branch 'main' into fix-pylance-imports

    @dangotbanned
    dangotbanned committed Jul 20, 2024
    Configuration menu
    Copy the full SHA
    1e0c12d View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2024

  1. revert: Include mixins, DataType, TOPLEVEL_ONLY_KEYS in `api.__… 

    …all__`

vega#3482 (comment)
    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    52c939c View commit details
    Browse the repository at this point in the history

  2. chore: remove TODO

    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    54723ec View commit details
    Browse the repository at this point in the history

  3. revert: include channels mixins and with_property_setters in `chann… 

    …els.__all__`
    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    f3ea6ff View commit details
    Browse the repository at this point in the history

  4. build: run generate-schema-wrapper

    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    13c2d87 View commit details
    Browse the repository at this point in the history

  5. build: run update-init-file

    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    d0dcc5d View commit details
    Browse the repository at this point in the history

  6. Merge remote-tracking branch 'upstream/main' into fix-pylance-imports

    @dangotbanned
    dangotbanned committed Jul 21, 2024
    Configuration menu
    Copy the full SHA
    050f16b View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2024

  1. Merge branch 'main' into fix-pylance-imports

    @dangotbanned
    dangotbanned committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    76d10e3 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into fix-pylance-imports

    @dangotbanned
    dangotbanned committed Jul 22, 2024
    Configuration menu
    Copy the full SHA
    fa65edd View commit details
    Browse the repository at this point in the history