Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: alt.themes -> alt.theme #3618

Open
wants to merge 40 commits into
base: main
Choose a base branch
from
Open

refactor: alt.themes -> alt.theme #3618

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
40 commits
Select commit Hold shift + click to select a range
54e7e48
chore: Add notes for change targets
dangotbanned Sep 28, 2024
66c51c3
chore: Add TODO in `update_init_file.py`
dangotbanned Sep 28, 2024
754f665
refactor: Remove `altair.vegalite.v5.theme` from `alt.__all__`
dangotbanned Sep 28, 2024
3dd9100
refactor: Add `alt.theme.py`
dangotbanned Sep 28, 2024
b1be633
build(typing): Generate `altair.vegalite.v5.schema.__init__.__all__`
dangotbanned Sep 29, 2024
0bd8f75
build: Generate `altair.vegalite.v5.__init__.__all__`
dangotbanned Sep 29, 2024
c996c95
refactor: `utils.theme` -> `vegalite.v5.theme`
dangotbanned Sep 29, 2024
c286c38
refactor: Remove `alt.typing.theme`
dangotbanned Sep 29, 2024
ef9b846
refactor: Adds `alt.theme` implementation
dangotbanned Sep 29, 2024
e8d3062
test: Fix `test_common`
dangotbanned Sep 29, 2024
f7fe38b
chore(typing): Remove now fix ignore comments
dangotbanned Sep 29, 2024
0a1c8d3
fix(typing): Use a bounded `TypeVar` to support `list[str]`
dangotbanned Sep 29, 2024
05eca89
refactor: Add deprecation handling `alt.__init__.__getattr__`
dangotbanned Sep 29, 2024
217d7fb
docs: Adds `alt.theme` to API Reference
dangotbanned Sep 29, 2024
5078f88
docs: Add missing `altair` qualifier for `TypedDict`(s)
dangotbanned Sep 29, 2024
2339116
fix(typing): Preserve generics in `PluginEnabler`
dangotbanned Sep 29, 2024
48e44c0
refactor: Refine and fully document `generate_schema__init__`
dangotbanned Sep 30, 2024
a7dbaca
refactor: Use new functions for part of `update__all__variable`
dangotbanned Sep 30, 2024
a0947f8
fix: Don't consider suffix a part in `path_to_module_str`
dangotbanned Sep 30, 2024
1e9f639
fix: Account for GH runner path
dangotbanned Sep 30, 2024
d895447
docs: Add link targets for API Reference sections
dangotbanned Sep 30, 2024
a9538bc
docs: Customize theme toctree order
dangotbanned Sep 30, 2024
e114493
docs: Update User Guide section
dangotbanned Sep 30, 2024
c8033b2
docs: Provide API ref link in warning
dangotbanned Sep 30, 2024
ef0f263
refactor: Remove unused `__future__` import
dangotbanned Sep 30, 2024
58da996
feat: Support `alt.theme.(active|options)`
dangotbanned Oct 1, 2024
bc507a9
fix(typing): Partial resolve `mypy` `__getattr__`
dangotbanned Oct 1, 2024
e0f4721
test: Rename test to `test_theme_register_decorator`
dangotbanned Oct 1, 2024
4e8def0
test: Add some more `(theme|themes)` equal checks
dangotbanned Oct 1, 2024
9bd0316
test: Add `test_theme_unregister`
dangotbanned Oct 1, 2024
0d95b44
feat: Raise instead of returning `None` in `unregister`
dangotbanned Oct 1, 2024
3e6bde8
docs: Update remaining `ThemeRegistry` methods
dangotbanned Oct 1, 2024
6141c7c
Merge branch 'main' into refac-alt-theme
dangotbanned Oct 2, 2024
d1ae98e
Merge branch 'main' into refac-alt-theme
dangotbanned Oct 3, 2024
2ca4b11
Merge branch 'main' into refac-alt-theme
dangotbanned Oct 5, 2024
d3dccab
Merge branch 'main' into refac-alt-theme
dangotbanned Oct 6, 2024
7c49b51
test: Adds `test_theme_remote_lambda`
dangotbanned Oct 11, 2024
a3e2d28
Merge branch 'main' into refac-alt-theme
dangotbanned Oct 12, 2024
a018165
docs: Suggest `alt.theme` instead of `alt.theme.themes`
dangotbanned Oct 12, 2024
98f4ed3
Merge branch 'main' into refac-alt-theme
dangotbanned Oct 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading