-
Notifications
You must be signed in to change notification settings - Fork 607
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update ts and fix typing issues #9066
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
This PR added the |
Sorry that this slipped off my radar (I was on vacation the week the PR was issued and then subsequently merged). |
I see. We should undo the specific change then. https://vega.github.io/vega-lite/docs/selection.html#selection-props is incorrect then, right? |
Co-authored-by: GitHub Actions Bot <[email protected]>
Co-authored-by: GitHub Actions Bot <[email protected]>
@arvind it looks like
fields
wasn't in interval selection configs but the docs and tests say it's a shared config option. Does this look right to you that I movedfilelds
?