Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not replace offset with main channel #9133

Closed
wants to merge 4 commits into from

Conversation

fandu-db
Copy link
Contributor

@fandu-db fandu-db commented Oct 11, 2023

Please:

  • Make the pull requests (PRs) atomic (fix one issue at a time). Multiple relevant issues that must be fixed together? Make atomic commits so we can easily review each issue.
  • Provide a concise title as a semantic commit message (e.g. "fix: correctly handle undefined properties") so we can easily copy it to the release note.
    • Use imperative mood and present tense.
  • Mention relevant issues in the description (e.g., Fixes #1 / Fixes part of #1).
  • Lint and test (Run yarn test).
  • Review your changes before sending the PR (to ensure code quality).
  • For new features:
    • Add new unit tests.
    • Update the documentation under site/docs/ + add examples.

Tips:

@kanitw kanitw requested review from lsh and a team October 12, 2023 04:08
Copy link
Member

@kanitw kanitw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fandu-db please take a look at my diff. If it looks good, we can merge squash.

@kanitw
Copy link
Member

kanitw commented Oct 12, 2023

replaced with #9135 since you branch doesn't seem to run the right github actions yet.

@kanitw kanitw closed this Oct 12, 2023
@kanitw kanitw deleted the fdu/do-not-replace-offset branch October 12, 2023 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants