dialect can be regular method

vega · Aug 10, 2023 · 513c3cc · 513c3cc
1 parent 684df5c
commit 513c3cc
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 4 deletions.
diff --git a/python/vegafusion/vegafusion/dataset/duckdb.py b/python/vegafusion/vegafusion/dataset/duckdb.py
@@ -7,8 +7,7 @@
 
 
 class DuckDbDataset(SqlDataset):
-    @classmethod
-    def dialect(cls) -> str:
+    def dialect(self) -> str:
         return "duckdb"
 
     def __init__(self, relation: DuckDBPyRelation, fallback: bool = True, verbose: bool = False):

diff --git a/python/vegafusion/vegafusion/dataset/sql.py b/python/vegafusion/vegafusion/dataset/sql.py
@@ -8,8 +8,7 @@ class SqlDataset(ABC):
     Python interface for VegaFusion Sql Dataset
     """
 
-    @classmethod
-    def dialect(cls) -> str:
+    def dialect(self) -> str:
         """
         Returns SQL dialect accepted by the connection