New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SqlDataset.dialect doesn't have to be a classmethod #372

Merged

jonmmease merged 1 commit into main from jonmmease/dialect_method

Aug 10, 2023

Collaborator

jonmmease commented Aug 10, 2023

The dialect method of the abstract SqlDataset class can be a regular method, rather than a classmethod.

This increases flexibility and allows SqlDataset subclasses to dynamically determine their dialect.


          dialect can be regular method

513c3cc

jonmmease merged commit 5982276 into main

30 checks passed

jonmmease deleted the jonmmease/dialect_method branch

August 10, 2023 22:26

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet