Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated project dependencies, Flurl, Vendr.Core and Micorsoft.AspNet.… #5

Open
wants to merge 1 commit into
base: v2/dev
Choose a base branch
from

Conversation

Maky55-hub
Copy link

…WebApi.Client. There were breaking changes between Flurl 2.0.0 to Flurl 3.0.0

…WebApi.Client. There were breaking changes between Flurl 2.0.0 to Flurl 3.0.0
@mattbrailsford
Copy link
Member

What's the need to upgrade the dependency?

@Maky55-hub
Copy link
Author

What's the need to upgrade the dependency?

For our project we created a Custom Payment Provider. For Paypal payments we wanted to use Vendr.PayPal.PaymentProvider. Our custom provider uses Flurl 3.2.4 while PayPal uses 2.4.2. This causes conflicts and we get the following exception evertime we want to use PayPal as PaymentProvider.

Method not found: 'Flurl.Http.HttpCall Flurl.Http.FlurlHttpException.get_Call()

In order to avoid this I downloaded the Paypal.PaymentProvider project and updated the dependencies, after which we could successfully do checkouts with PayPal.

@mattbrailsford
Copy link
Member

Yea, I thought so. This is also the reason I can’t accept this on its own. A number of other supported providers make use of Flurl and we ensure they all use the same version to protect against conflicts. If we accept this PR we must upgrade all the payment providers we have that use Flurl too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants